improvement(helm): add internal ingress support and same-host path consolidation #2960

waleedlatif1 · 2026-01-24T02:13:51Z

Summary

Add internal ingress template for private/internal load balancer access
Update ingress to consolidate paths when app/realtime/copilot share same host
Add ingressInternal values with cloud provider annotation examples

Type of Change

Improvement (enhancement to existing feature)

Testing

Tested with helm lint and helm template - both pass

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…nsolidation

vercel · 2026-01-24T02:13:56Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
docs	Ready	Preview, Comment	Jan 24, 2026 2:40am

greptile-apps · 2026-01-24T02:16:29Z

Greptile Summary

This PR enhances Helm chart ingress configuration by adding support for internal load balancers and implementing intelligent path consolidation when multiple services share the same hostname.

Key Changes:

Added new ingress-internal.yaml template for private/internal ingress resources with cloud-agnostic configuration
Implemented smart path consolidation logic in both public and internal ingress templates - when app, realtime, and copilot services use the same host, their paths are consolidated under a single ingress rule instead of creating duplicate rules
Added ingressInternal values section with examples for Azure, AWS, and GCP internal load balancer annotations
Updated values-azure.yaml example with comprehensive internal ingress configuration

Impact:
The path consolidation prevents Kubernetes from rejecting ingress configurations with duplicate host entries, enabling simpler same-domain deployments (e.g., app at /, realtime at /socket.io, copilot at /copilot). The internal ingress support allows private VNet/VPC access patterns common in enterprise deployments.

Confidence Score: 5/5

This PR is safe to merge with no risk - it only adds infrastructure configuration options without modifying existing behavior
The changes are purely additive infrastructure configuration (new template file and values) with no modifications to application logic. The path consolidation logic is sound and uses proper Kubernetes conditional templating. Author tested with helm lint and helm template, both passed. No runtime code changes, no security concerns.
No files require special attention

Important Files Changed

Filename	Overview
helm/sim/templates/ingress.yaml	Updated to consolidate paths when services share the same host, avoiding duplicate ingress rules
helm/sim/templates/ingress-internal.yaml	New template for internal ingress with same path consolidation logic as public ingress
helm/sim/values.yaml	Added ingressInternal configuration section with cloud provider annotation examples
helm/sim/examples/values-azure.yaml	Added ingressInternal example configuration with Azure-specific annotations and documentation

Sequence Diagram

sequenceDiagram
    participant User as Deployment Engineer
    participant Helm as Helm Chart
    participant K8s as Kubernetes API
    participant Ingress as Ingress Controller
    participant App as App Service
    participant Realtime as Realtime Service
    participant Copilot as Copilot Service

    User->>Helm: helm install with values
    
    alt Internal Ingress Enabled
        Helm->>Helm: Check ingressInternal.enabled=true
        Helm->>Helm: Evaluate host matching logic
        
        alt Same Host for All Services
            Note over Helm: app.host = realtime.host = copilot.host
            Helm->>K8s: Create single ingress rule
            Helm->>K8s: Add /socket.io → Realtime backend
            Helm->>K8s: Add /copilot → Copilot backend
            Helm->>K8s: Add / → App backend
        else Different Hosts
            Note over Helm: Hosts differ
            Helm->>K8s: Create separate ingress rules per host
        end
        
        Helm->>K8s: Apply internal ingress with private IP annotations
        K8s->>Ingress: Configure internal load balancer
    end
    
    alt Public Ingress Enabled
        Helm->>Helm: Check ingress.enabled=true
        Helm->>Helm: Apply same consolidation logic
        Helm->>K8s: Create public ingress rules
        K8s->>Ingress: Configure public load balancer
    end
    
    Ingress->>App: Route / requests
    Ingress->>Realtime: Route /socket.io requests
    Ingress->>Copilot: Route /copilot requests

greptile-apps

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

helm/sim/templates/ingress.yaml

helm/sim/templates/ingress-internal.yaml

Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <[email protected]>

When copilot.host equals realtime.host but differs from app.host, copilot paths were not being routed. Added logic to consolidate copilot paths into the realtime rule for this scenario. Co-Authored-By: Claude Opus 4.5 <[email protected]>

helm/sim/templates/ingress-internal.yaml

- Remove orphan comments that appeared when services were disabled - Add documentation about path ordering requirements - Paths rendered in order: realtime, copilot, app (specific before catch-all) - Clean template output matching industry Helm chart standards

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

helm/sim/templates/ingress.yaml

…2973) * fix(subflows): tag dropdown + resolution logic (#2949) * fix(subflows): tag dropdown + resolution logic * fixes; * revert parallel change * chore(deps): bump posthog-js to 1.334.1 (#2948) * fix(idempotency): add conflict target to atomicallyClaimDb query + remove redundant db namespace tracking (#2950) * fix(idempotency): add conflict target to atomicallyClaimDb query * delete needs to account for namespace * simplify namespace filtering logic * fix cleanup * consistent target * improvement(kb): add document filtering, select all, and React Query migration (#2951) * improvement(kb): add document filtering, select all, and React Query migration * test(kb): update tests for enabledFilter and removed userId params * fix(kb): remove non-null assertion, add explicit guard * improvement(logs): trace span, details (#2952) * improvement(action-bar): ordering * improvement(logs): details, trace span * feat(blog): v0.5 release post (#2953) * feat(blog): v0.5 post * improvement(blog): simplify title and remove code block header - Simplified blog title from "Introducing Sim Studio v0.5" to "Introducing Sim v0.5" - Removed language label header and copy button from code blocks for cleaner appearance Co-Authored-By: Claude Opus 4.5 <[email protected]> * ack PR comments * small styling improvements * created system to create post-specific components * updated componnet * cache invalidation --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * feat(admin): add credits endpoint to issue credits to users (#2954) * feat(admin): add credits endpoint to issue credits to users * fix(admin): use existing credit functions and handle enterprise seats * fix(admin): reject NaN and Infinity in amount validation * styling * fix(admin): validate userId and email are strings * improvement(copilot): fast mode, subagent tool responses and allow preferences (#2955) * Improvements * Fix actions mapping * Remove console logs * fix(billing): handle missing userStats and prevent crashes (#2956) * fix(billing): handle missing userStats and prevent crashes * fix(billing): correct import path for getFilledPillColor * fix(billing): add Number.isFinite check to lastPeriodCost * fix(logs): refresh logic to refresh logs details (#2958) * fix(security): add authentication and input validation to API routes (#2959) * fix(security): add authentication and input validation to API routes * moved utils * remove extraneous commetns * removed unused dep * improvement(helm): add internal ingress support and same-host path consolidation (#2960) * improvement(helm): add internal ingress support and same-host path consolidation * improvement(helm): clean up ingress template comments Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <[email protected]> * fix(helm): add missing copilot path consolidation for realtime host When copilot.host equals realtime.host but differs from app.host, copilot paths were not being routed. Added logic to consolidate copilot paths into the realtime rule for this scenario. Co-Authored-By: Claude Opus 4.5 <[email protected]> * improvement(helm): follow ingress best practices - Remove orphan comments that appeared when services were disabled - Add documentation about path ordering requirements - Paths rendered in order: realtime, copilot, app (specific before catch-all) - Clean template output matching industry Helm chart standards --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * feat(blog): enterprise post (#2961) * feat(blog): enterprise post * added more images, styling * more content * updated v0-5 post * remove unused transition --------- Co-authored-by: Vikhyath Mondreti <[email protected]> * fix(envvars): resolution standardized (#2957) * fix(envvars): resolution standardized * remove comments * address bugbot * fix highlighting for env vars * remove comments * address greptile * address bugbot * fix(copilot): mask credentials fix (#2963) * Fix copilot masking * Clean up * Lint * improvement(webhooks): remove dead code (#2965) * fix(webhooks): subscription recreation path * improvement(webhooks): remove dead code * fix tests * address bugbot comments * fix restoration edge case * fix more edge cases * address bugbot comments * fix gmail polling * add warnings for UI indication for credential sets * fix(preview): subblock values (#2969) * fix(child-workflow): nested spans handoff (#2966) * fix(child-workflow): nested spans handoff * remove overly defensive programming * update type check * type more code * remove more dead code * address bugbot comments * fix(security): restrict API key access on internal-only routes (#2964) * fix(security): restrict API key access on internal-only routes * test(security): update function execute tests for checkInternalAuth * updated agent handler * move session check higher in checkSessionOrInternalAuth * extracted duplicate code into helper for resolving user from jwt * fix(copilot): update copilot chat title (#2968) * fix(hitl): fix condition blocks after hitl (#2967) * fix(notes): ghost edges (#2970) * fix(notes): ghost edges * fix deployed state fallback * fallback * remove UI level checks * annotation missing from autoconnect source check * improvement(docs): loop and parallel var reference syntax (#2975) * fix(blog): slash actions description (#2976) * improvement(docs): loop and parallel var reference syntax * fix(blog): slash actions description * fix(auth): copilot routes (#2977) * Fix copilot auth * Fix * Fix * Fix * fix(copilot): fix edit summary for loops/parallels (#2978) * fix(integrations): hide from tool bar (#2544) * fix(landing): ui (#2979) * fix(edge-validation): race condition on collaborative add (#2980) * fix(variables): boolean type support and input improvements (#2981) * fix(variables): boolean type support and input improvements * fix formatting --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: Emir Karabeg <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Siddharth Ganesan <[email protected]> Co-authored-by: Vikhyath Mondreti <[email protected]>

…2973) * fix(subflows): tag dropdown + resolution logic (#2949) * fix(subflows): tag dropdown + resolution logic * fixes; * revert parallel change * chore(deps): bump posthog-js to 1.334.1 (#2948) * fix(idempotency): add conflict target to atomicallyClaimDb query + remove redundant db namespace tracking (#2950) * fix(idempotency): add conflict target to atomicallyClaimDb query * delete needs to account for namespace * simplify namespace filtering logic * fix cleanup * consistent target * improvement(kb): add document filtering, select all, and React Query migration (#2951) * improvement(kb): add document filtering, select all, and React Query migration * test(kb): update tests for enabledFilter and removed userId params * fix(kb): remove non-null assertion, add explicit guard * improvement(logs): trace span, details (#2952) * improvement(action-bar): ordering * improvement(logs): details, trace span * feat(blog): v0.5 release post (#2953) * feat(blog): v0.5 post * improvement(blog): simplify title and remove code block header - Simplified blog title from Introducing Sim Studio v0.5 to Introducing Sim v0.5 - Removed language label header and copy button from code blocks for cleaner appearance Co-Authored-By: Claude Opus 4.5 <[email protected]> * ack PR comments * small styling improvements * created system to create post-specific components * updated componnet * cache invalidation --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * feat(admin): add credits endpoint to issue credits to users (#2954) * feat(admin): add credits endpoint to issue credits to users * fix(admin): use existing credit functions and handle enterprise seats * fix(admin): reject NaN and Infinity in amount validation * styling * fix(admin): validate userId and email are strings * improvement(copilot): fast mode, subagent tool responses and allow preferences (#2955) * Improvements * Fix actions mapping * Remove console logs * fix(billing): handle missing userStats and prevent crashes (#2956) * fix(billing): handle missing userStats and prevent crashes * fix(billing): correct import path for getFilledPillColor * fix(billing): add Number.isFinite check to lastPeriodCost * fix(logs): refresh logic to refresh logs details (#2958) * fix(security): add authentication and input validation to API routes (#2959) * fix(security): add authentication and input validation to API routes * moved utils * remove extraneous commetns * removed unused dep * improvement(helm): add internal ingress support and same-host path consolidation (#2960) * improvement(helm): add internal ingress support and same-host path consolidation * improvement(helm): clean up ingress template comments Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <[email protected]> * fix(helm): add missing copilot path consolidation for realtime host When copilot.host equals realtime.host but differs from app.host, copilot paths were not being routed. Added logic to consolidate copilot paths into the realtime rule for this scenario. Co-Authored-By: Claude Opus 4.5 <[email protected]> * improvement(helm): follow ingress best practices - Remove orphan comments that appeared when services were disabled - Add documentation about path ordering requirements - Paths rendered in order: realtime, copilot, app (specific before catch-all) - Clean template output matching industry Helm chart standards --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * feat(blog): enterprise post (#2961) * feat(blog): enterprise post * added more images, styling * more content * updated v0-5 post * remove unused transition --------- Co-authored-by: Vikhyath Mondreti <[email protected]> * fix(envvars): resolution standardized (#2957) * fix(envvars): resolution standardized * remove comments * address bugbot * fix highlighting for env vars * remove comments * address greptile * address bugbot * fix(copilot): mask credentials fix (#2963) * Fix copilot masking * Clean up * Lint * improvement(webhooks): remove dead code (#2965) * fix(webhooks): subscription recreation path * improvement(webhooks): remove dead code * fix tests * address bugbot comments * fix restoration edge case * fix more edge cases * address bugbot comments * fix gmail polling * add warnings for UI indication for credential sets * fix(preview): subblock values (#2969) * fix(child-workflow): nested spans handoff (#2966) * fix(child-workflow): nested spans handoff * remove overly defensive programming * update type check * type more code * remove more dead code * address bugbot comments * fix(security): restrict API key access on internal-only routes (#2964) * fix(security): restrict API key access on internal-only routes * test(security): update function execute tests for checkInternalAuth * updated agent handler * move session check higher in checkSessionOrInternalAuth * extracted duplicate code into helper for resolving user from jwt * fix(copilot): update copilot chat title (#2968) * fix(hitl): fix condition blocks after hitl (#2967) * fix(notes): ghost edges (#2970) * fix(notes): ghost edges * fix deployed state fallback * fallback * remove UI level checks * annotation missing from autoconnect source check * improvement(docs): loop and parallel var reference syntax (#2975) * fix(blog): slash actions description (#2976) * improvement(docs): loop and parallel var reference syntax * fix(blog): slash actions description * fix(auth): copilot routes (#2977) * Fix copilot auth * Fix * Fix * Fix * fix(copilot): fix edit summary for loops/parallels (#2978) * fix(integrations): hide from tool bar (#2544) * fix(landing): ui (#2979) * fix(edge-validation): race condition on collaborative add (#2980) * fix(variables): boolean type support and input improvements (#2981) * fix(variables): boolean type support and input improvements * fix formatting --------- Co-authored-by: Vikhyath Mondreti <[email protected]> Co-authored-by: Emir Karabeg <[email protected]> Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Siddharth Ganesan <[email protected]> Co-authored-by: Vikhyath Mondreti <[email protected]>

improvement(helm): add internal ingress support and same-host path co…

13d28e7

…nsolidation

vercel bot deployed to Preview January 24, 2026 02:15 View deployment

greptile-apps bot reviewed Jan 24, 2026

View reviewed changes

helm/sim/templates/ingress.yaml Outdated Show resolved Hide resolved

cursor bot reviewed Jan 24, 2026

View reviewed changes

helm/sim/templates/ingress-internal.yaml Show resolved Hide resolved

improvement(helm): clean up ingress template comments

b96078b

Simplify verbose inline Helm comments and section dividers to match the minimal style used in services.yaml. Co-Authored-By: Claude Opus 4.5 <[email protected]>

vercel bot deployed to Preview January 24, 2026 02:23 View deployment

vercel bot deployed to Preview January 24, 2026 02:28 View deployment

cursor bot reviewed Jan 24, 2026

View reviewed changes

helm/sim/templates/ingress-internal.yaml Show resolved Hide resolved

vercel bot deployed to Preview January 24, 2026 02:40 View deployment

cursor bot reviewed Jan 24, 2026

View reviewed changes

helm/sim/templates/ingress.yaml Show resolved Hide resolved

waleedlatif1 merged commit f0ee67f into staging Jan 24, 2026
11 checks passed

waleedlatif1 deleted the improvement/helm branch January 24, 2026 02:44

waleedlatif1 mentioned this pull request Jan 24, 2026

v0.5.69: kb upgrades, blog, copilot improvements, auth consolidation #2973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improvement(helm): add internal ingress support and same-host path consolidation #2960

improvement(helm): add internal ingress support and same-host path consolidation #2960

Uh oh!

waleedlatif1 commented Jan 24, 2026

Uh oh!

vercel bot commented Jan 24, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 24, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

improvement(helm): add internal ingress support and same-host path consolidation #2960

improvement(helm): add internal ingress support and same-host path consolidation #2960

Uh oh!

Conversation

waleedlatif1 commented Jan 24, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Jan 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 24, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 24, 2026 •

edited

Loading